Closed mpacer closed 5 years ago
Merging #139 into master will increase coverage by
2.55%
. The diff coverage is72.72%
.
@@ Coverage Diff @@
## master #139 +/- ##
==========================================
+ Coverage 74.87% 77.43% +2.55%
==========================================
Files 10 10
Lines 414 421 +7
==========================================
+ Hits 310 326 +16
+ Misses 104 95 -9
I wanted to set us up for success going forward around cloning.
The difficulty we were having getting coverage in the tests suggested to me that we hadn't properly isolated the different pieces of the logic. When I started diving in it became clear that the internal logic of the clone API handler could use a lot of attention & refactoring.
Once the refactor was done it was fairly straightforward to test.
Also made general improvements
Overall the code should be much easier to follow.