Closed mpacer closed 5 years ago
Merging #146 into master will decrease coverage by
0.28%
. The diff coverage is40%
.
@@ Coverage Diff @@
## master #146 +/- ##
==========================================
- Coverage 79.57% 79.29% -0.29%
==========================================
Files 10 10
Lines 426 425 -1
==========================================
- Hits 339 337 -2
- Misses 87 88 +1
Merging #146 into master will decrease coverage by
0.28%
. The diff coverage is40%
.
@@ Coverage Diff @@
## master #146 +/- ##
==========================================
- Coverage 79.57% 79.29% -0.29%
==========================================
Files 10 10
Lines 426 425 -1
==========================================
- Hits 339 337 -2
- Misses 87 88 +1
@willingc are you comfortable with us merging this? There's not going to be an easy way to avoid dropping code coverage while fixing this bug :/.
-0.29% for refactoring isn't a problem worth blocking a merge imho
This addresses #145 for now. However it does not clarify why the issue arose in the first place.
It is likely that this results in a slightly lower coverage report.
But, it has some advantages: