nteract / bookstore

📚 Notebook storage and publishing workflows for the masses

https://bookstore.readthedocs.io

BSD 3-Clause "New" or "Revised" License

202 stars 23 forks source link

End to End testing Cloning Landing page #159

Closed mpacer closed 5 years ago

mpacer commented 5 years ago

Builds on #158, adding the route to the server so this can be tested directly.

codecov[bot] commented 5 years ago

Codecov Report

Merging #159 into master will increase coverage by 0.24%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
+ Coverage   80.91%   81.15%   +0.24%     
==========================================
  Files          10       10              
  Lines         461      467       +6     
==========================================
+ Hits          373      379       +6     
  Misses         88       88

mpacer commented 5 years ago

Spoke with @chyzzqo2 offline and talked through the fact that we should not be adding the route in the first place if the basedir is not correctly configured.

This required adding stronger checks to the validate_bookstore function as well as logging.

I created #160 to track progress around adding logging to the other bookstore setting values.

willingc commented 5 years ago

Thanks @mpacer. :sunny: