Closed willingc closed 5 years ago
TODO
comment in e1f8f5b3be85b22ca1bf38b9e301d6e133f5dc39 in #89. cc @willingc.@captainsafia did I not address your concern by creating a getCookieByName
function as you had requested? I'm a little confused as to what needs to be addressed here…
Catching up with this conversation.
I was referring to creating a getCookieByName function that did not use regex. The getCookie method used in the notebook code base is copied from the Tornado docs. While it suffices, I think an alternate approach (like splitting on semi-colons and parsing the key values) is easier to read. It's also the approach taken by the js-cookie package that we use rx-jupyter.
Opened #104 and closing this PR in preparation for release.