Closed willingc closed 5 years ago
TODO
comment in 5eba02bf1b5efb616b0aa8cd62e756bec688a642 in #90. cc @willingc.TODO
comment in 5eba02bf1b5efb616b0aa8cd62e756bec688a642 in #90. cc @willingc.TODO
comment in 5eba02bf1b5efb616b0aa8cd62e756bec688a642 in #90. cc @willingc.TODO
comment in 5eba02bf1b5efb616b0aa8cd62e756bec688a642 in #90. cc @willingc.TODO
comment in 5eba02bf1b5efb616b0aa8cd62e756bec688a642 in #90. cc @willingc.TODO
comment in 5eba02bf1b5efb616b0aa8cd62e756bec688a642 in #90. cc @willingc.TODO
comment in 5eba02bf1b5efb616b0aa8cd62e756bec688a642 in #90. cc @willingc.@MSeal re: your comments on testing.
I would love your insight on how to test the various clients. I am super enthusiastic about that just had a tricky time getting that to start as to do it properly requires some pretty extensive integration test work.
Regarding the cloning functionality itself that was introduced in #75, that was what the js based integration tests were testing.
@mpacer I would argue we need unittests first here most of all. You'll need to mock s3 and web interfaces above and below the various functions, but there's a lot of logic here for handling edge cases that need coverage for reliable development. A starting place would be to get a test for clone get
receiving and empty file path. I can help set up first first couple tests when I get back if it'd help get the ball rolling.
TODO
comment in f1b45689591823169cdd1dbc36e94f3d4afef58c in #90. cc @willingc.TODO
comment in 8bb2fb74aaac861b7454ed4710d6b6d2eb0ca0c4 in #90. cc @willingc.TODO
comment in 671251822865f455c54b1ad9fec21ef7494198eb in #90. cc @willingc.TODO
comment in d1d5c2b14fc95713fe7ce6420eccff9cc4a34d56 in #90. cc @willingc.@mpacer I spent some time this morning going through this PR in detail. All tests are passing (thanks to M's fix to the js ci - changing const to let). Let's merge this and move forward.
We're getting very close to a release. Just a few more tests and a changelog after this lands.
@mpacer I think that this has all the changes that we discussed on our call.