search

nteract / coffee_boat

☕⛵WIP PySpark dependency management
BSD 3-Clause "New" or "Revised" License
22 stars 10 forks source link

Add support for installing Python packages on an existing context #36

Closed holdenk closed 6 years ago

holdenk commented 6 years ago

I have a mediocre feeling about this, but for notebook users re-launching the ship everytime they add a new package probably isn't a lot of fun.

holdenk commented 6 years ago

I'll leave this open for ~8 hours incase anyone has comments then I'll just merge otherwise :)

rgbkrk commented 6 years ago

Do you want me to squash merge when you're running through exploratory commits? I do the same too and end up squashing mine, it's up to you as the lead on this though. 😄

holdenk commented 6 years ago

Thanks for merging, and in general I also tend to do squash when merging something exploratory like this :) (Some folks tell me I should squash locally but I like to show the process for if/when I come back to look through the PR and figure out what the hell I did :p)