search

nteract / commuter

🚎 Notebook sharing hub
BSD 3-Clause "New" or "Revised" License
489 stars 66 forks source link

Failed to compile #271

Open MycoBean opened 4 years ago

MycoBean commented 4 years ago

I built application from master using Development Quick Start instructions in Readme.md, and launch application with local storage backend using yarn dev.

I get served the local storage base directory at http://localhost:4000. However, on clicking any folder I get the following error:

Failed to compile ./node_modules/@nteract/vega-embed-v3/dist/index.esm.js Module not found: Can't resolve 'd3-voronoi' in '/home/jupyter/commuter/node_modules/@nteract/vega-embed-v3/dist'

Any suggestions on how to fix?

captainsafia commented 4 years ago

Thanks for opening this issue @MycoBean!

It appears that the dependencies in the vega-embed package need to be updated. I'll go ahead and fix this and release a new version of vega-embed-v3 and commuter to resolve this.

dhpollack commented 4 years ago

@captainsafia I also built from master and get the following error:

ModuleNotFoundError: Module not found: Error: Can't resolve 'd3-contour'

I didn't see d3-contour in your PR on the vega-embed-v3 PR, although it could be a subdependency of something that you've already added.

captainsafia commented 4 years ago

I didn't see d3-contour in your PR on the vega-embed-v3 PR, although it could be a subdependency of something that you've already added.

To be honest, it's been a while since I worked on that PR so I can't recall why that module is omitted from the list of added ones. I do recall spending quite a bit of time formulating that list so I think it might have been a sub-dependency. I can verify this.