Feature Request: Configurable context path or prefix URL

nteract / commuter

🚎 Notebook sharing hub

BSD 3-Clause "New" or "Revised" License

495 stars 66 forks source link

Feature Request: Configurable context path or prefix URL #328

Open ricecooker opened 3 years ago

ricecooker commented 3 years ago

By default commuter runs on http://hostname:4000/

Could we add a parameter such as COMMUTER_URL_PREFIX that could change the URL?

As an example if I were to do this:

export COMMUTER_URL_PREFIX=commuter/

Then commuter would respond to this: http://hostname:4000/commuter/

I have a build server with nginx in front that I'd like to host commuter so people can easily lookup their papermill jobs that run.

captainsafia commented 3 years ago

Thanks for sharing this recommendation, @ricecooker! Are you interested in submitting a PR for this? Happy to point you to the right places.

ricecooker commented 3 years ago

Sure, I'm open to exploring. NodeJS is not usually my cup of tea but I'm happy to try learn. I noticed some references to baseUrl in the codebase and this feature seems to already be on the roadmap (sorry!).

For anyone else needing this now, I found https://github.com/line/jnotebook_reader that does support this. I'd like to stick with nteract/commuter since we use papermill a lot.