nteract / enchannel-zmq-backend

ZeroMQ backend implementation for enchannel
BSD 3-Clause "New" or "Revised" License
5 stars 17 forks source link

Interface iterations #1

Closed rgbkrk closed 8 years ago

rgbkrk commented 8 years ago
rgbkrk commented 8 years ago

As for 1, we do need to be able to dispose of the underlying socket, via onCompleted. It does make sense to be a subject then. It just shouldn't try to send messages across. Tempting to make subj.close = subj.onCompleted, just like subj.send = subj.onNext. Carries the intent better, which is my answer to (2).

For (3), I'm wondering if there is a better approach to handling these from Rx. I technically want to be able to use the Observer without making a subscription to the Observable.