search

nteract / enchannel-zmq-backend

ZeroMQ backend implementation for enchannel
BSD 3-Clause "New" or "Revised" License
5 stars 17 forks source link

Switch to RxJS 5 #11

Closed rgbkrk closed 8 years ago

rgbkrk commented 8 years ago

The RxJS team is stellar and has convinced me we should just switch on over to RxJS 5. @kenwheeler is going to switch composition to RxJS 5 too.

We'll need to update the enchannel spec while we're at it for any interface changes.

/cc @blesh

benlesh commented 8 years ago

Cool. Let us know if you run into any issues.

rgbkrk commented 8 years ago

Only thing that caused me to misstep was the change to Subject.create, which I submitted a Doc PR for: https://github.com/ReactiveX/RxJS/pull/1241

The reason it took me a while to find this was my current three sources for docs:

I finally started digging around in making the Observable and Observers directly until I finally figured out I was running into issues with Subject.create. We're using pretty vanilla operators here, so it wasn't a big deal.