search

nteract / enchannel-zmq-backend

ZeroMQ backend implementation for enchannel
BSD 3-Clause "New" or "Revised" License
5 stars 17 forks source link

Full cleanup #3

Closed rgbkrk closed 8 years ago

rgbkrk commented 8 years ago

Ensure all the listeners are removed when onCompleted is called. Additionally, alias onCompleted to close.

In the future, we'll want to create a subclass of Subject that has close and send defined (so we're not declaring it on each instance). It may be that there's little performance penalty for this though since we only do it once.

rgbkrk commented 8 years ago

Since I switched io to iopub in name, I'll have to bump the minor rev.

rgbkrk commented 8 years ago

Should have kept that io in there to be backwards compatible for the sake of good practices (and made a Major release...). I'm the only user though of this day old library, so we'll sweep that under the rug!