search

nteract / enchannel-zmq-backend

ZeroMQ backend implementation for enchannel
BSD 3-Clause "New" or "Revised" License
5 stars 17 forks source link

Refactor subjects #48

Closed rgbkrk closed 7 years ago

rgbkrk commented 7 years ago

By personal request by @williamstein, I've taken out the message freezing. A user can do this themselves by mapping over the stream if they really want the objects frozen.

One minor refactor of the subscriber creation to not squash errors from sockets (thanks @jayphelps).

While I was at it I ran prettier over the code base. 💅

rgbkrk commented 7 years ago

I also realize you're not using this anymore @williamstein, figured I'd go ahead and follow up on this regardless as I ready more of this for web-based nteract.

rgbkrk commented 7 years ago

I'll ship a major release of this, though there may be another major release coming in the next few weeks if I switch to extending subject instead as pointed out to me by Jay earlier today (for https://github.com/nteract/nteract/issues/874)

rgbkrk commented 7 years ago

Shipped!

Now to let greenkeeper handle the upgrade on nteract while I work on some other things.