Fix bug while checking for an old version

nteract / hydrogen

:atom: Run code interactively, inspect data, and plot. All the power of Jupyter kernels, inside your favorite text editor.

https://nteract.gitbooks.io/hydrogen/

MIT License

3.91k stars 335 forks source link

Fix bug while checking for an old version #2162

Closed mauricioszabo closed 1 year ago

mauricioszabo commented 1 year ago

We're keeping a fork of Atom called Pulsar. We decided that our "first beta version" was going to be 1.100, but the way Hydrogen checks for versions is using parseFloat, which translates 1.100 to 1.1 and then it proceeds to use some outdated API.

This PR removes the check (Atom 1.2 is really old and considering that the project is dead anyway...)

LRydin commented 1 year ago

I second this. I am facing an issue due to this.

shr00mie commented 1 year ago

I second this. I am facing an issue due to this.

i fif this.