search

nteract / markdown

A package for rendering Markdown within Jupyter notebooks
BSD 3-Clause "New" or "Revised" License
9 stars 8 forks source link

bring back html parsing of markdown entries #16

Closed rgbkrk closed 3 years ago

rgbkrk commented 3 years ago

This allows for rendering HTML that is embedded in a Markdown cell or output. We started noticing this in some papermill output notebooks that used a simple <span tag with styling.

Alternatively, we could fold in astPlugins overrides more directly than the current ...props splat here.

rgbkrk commented 3 years ago

I assume this is meant to work when you are running the markdown component in a trusted environment?

Yeah. I'd love to be able to support some subset, like is done with Github markdown.

We could make this opt-in either by merging in props.astPlugins properly (appending it to the array).

stormpython commented 3 years ago

I updated this PR. Would you mind taking a look @captainsafia?

stormpython commented 3 years ago

I removed the html-parser import and the type file related to the parser function. I am going to go ahead and merge this now.