nteract / notebook-render

3 stars 8 forks source link

Support react-markdown >=4.2.0 and fix typescript errors #2

Open sdobz opened 4 years ago

sdobz commented 4 years ago

Fixes #1 by adding a renderer for the "element" node type as output by the rehype plugin now executing due to a change in how react-markdown executes plugins

Also includes additional typescript definitions, and using a discriminated union to switch on cell_type.

@markmo I see you have a fairly current fork that makes many changes to rendering as well as using tsc-transpile-only. These two forks probably have merge conflicts. Commit 88ae472 is the only important one, though some of the typing changes might be of interest to you

sdobz commented 4 years ago

The markmo branch includes those changes, which turn out to be important to getting results displaying