search

nteract / papermill

📚 Parameterize, execute, and analyze notebooks
http://papermill.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
5.97k stars 429 forks source link

bring back strip_color and remove ANSI color codes from exception traceback #791

Closed mbektas closed 7 months ago

mbektas commented 7 months ago

https://github.com/nteract/papermill/pull/681 removed ansiwrap dependency and strip_color used to clean up ANSI color codes from exception outputs. That is a breaking change and preventing us to use the latest papermill version.

This PR brings in only the strip_color implementation from ansiwrap package and uses it to remove ANSI color codes as the versions <= 2.4.0 did.

codecov[bot] commented 7 months ago

Codecov Report

Merging #791 (0409031) into main (cb2eb37) will decrease coverage by 0.25%. Report is 9 commits behind head on main. The diff coverage is 100.00%.

:exclamation: Current head 0409031 differs from pull request most recent head 7a6dc45. Consider uploading reports for the commit 7a6dc45 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #791 +/- ## ========================================== - Coverage 91.54% 91.29% -0.25% ========================================== Files 17 17 Lines 1621 1632 +11 ========================================== + Hits 1484 1490 +6 - Misses 137 142 +5 ```
mbektas commented 7 months ago

@MSeal would you be able to check out this one as well before the next release? thanks!