search

nteract / play

The code base for the nteract Play app
https://play.nteract.io/
BSD 3-Clause "New" or "Revised" License
13 stars 19 forks source link

[play] Kill old server after changing servers #10

Open rgbkrk opened 6 years ago

rgbkrk commented 6 years ago

ref: #2236

Maintainers: feel free to edit/update the description here.

/cc @mpacer @theengineear

mpacer commented 6 years ago

It does seem like this feature already exists via

https://github.com/nteract/nteract/blob/82611f8e92949da8e145ecb38b19b6e828e13a1c/applications/play/components/Main.js#L54-L60

What needs to be made is the server killing feature, which currently has no epic (see the comments):

https://github.com/nteract/nteract/blob/82611f8e92949da8e145ecb38b19b6e828e13a1c/applications/play/redux/epics.js#L44-L48

So should we change this issue to be "kill oldServer after changing servers"?

Or is there a way in which this functionality is missing that I'm misunderstanding?

rgbkrk commented 6 years ago

That sounds right. I just copied over the text that was in the top of the originating PR.

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 5 years ago

This issue hasn't had any activity on it in the last 90 days. Unfortunately we don't get around to dealing with every issue that is opened. Instead of leaving issues open we're seeking to be transparent by closing issues that aren't being prioritized. If no other activity happens on this issue in one week, it will be closed. It's more than likely that just by me posting about this, the maintainers will take a closer look at these long forgotten issues to help evaluate what to do next. If you would like to see this issue get prioritized over others, there are multiple avenues 🗓:

Thank you!