search

nteract / rx-jupyter

🎈 RxJS 5 bindings for the Jupyter Notebook API
https://nteract.io/rx-jupyter
BSD 3-Clause "New" or "Revised" License
13 stars 10 forks source link

Contents API #16

Closed rgbkrk closed 7 years ago

rgbkrk commented 7 years ago

This is a small portion of the contents API, mostly enough for a little dashboard view like /tree on the jupyter notebook server:

screen shot 2016-10-22 at 11 01 57 am

This will be ready when I have tests in place for all the functions written here. The other API calls I'll be willing to handle on another PR (or leave for someone else).

codecov-io commented 7 years ago

Current coverage is 100% (diff: 100%)

Merging #16 into master will not change coverage

@@           master   #16   diff @@
===================================
  Files           4     5     +1   
  Lines          51    69    +18   
  Methods         0     0          
  Messages        0     0          
  Branches        0     0          
===================================
+ Hits           51    69    +18   
  Misses          0     0          
  Partials        0     0

Powered by Codecov. Last update c7ab4e6...1d2f80b

jdetle commented 7 years ago

Merge?

rgbkrk commented 7 years ago

Look at all the tests! Thanks John!

I can address the feedback from Safia on params here still, or we can make sure we adapt it before release (so we don't have to deal with semver changes).

rgbkrk commented 7 years ago

Are we missing any other query parameters on other APIs?