chore(contents): delete unused function

nteract / rx-jupyter

🎈 RxJS 5 bindings for the Jupyter Notebook API

https://nteract.io/rx-jupyter

BSD 3-Clause "New" or "Revised" License

13 stars 10 forks source link

chore(contents): delete unused function #21

Closed rgbkrk closed 8 years ago

rgbkrk commented 8 years ago

Now I see how coverage went down in the ajax settings refactor PR I made. I simplified things enough to not need this function anymore, which meant that it was sitting there without being used and therefore not covered.

Let's take it out.

I also realize now that we should definitely only export the names we want from each module kernels, kernelspecs, etc. so that we're not leaking out the createSettings* functions to our primary namespace.

codecov-io commented 8 years ago

Current coverage is 100% (diff: 100%)

Merging #21 into master will increase coverage by 2.77%

@@             master   #21   diff @@
=====================================
  Files             6     6          
  Lines            72    70     -2   
  Methods           0     0          
  Messages          0     0          
  Branches          0     0          
=====================================
  Hits             70    70          
+ Misses            2     0     -2   
  Partials          0     0

Powered by Codecov. Last update b22b795...acddcf0