search

nteract / rx-jupyter

🎈 RxJS 5 bindings for the Jupyter Notebook API
https://nteract.io/rx-jupyter
BSD 3-Clause "New" or "Revised" License
13 stars 10 forks source link

refactor(kernelspecs): tear out createAJAXSettings #24

Closed rgbkrk closed 7 years ago

rgbkrk commented 7 years ago

Similar to #22

rgbkrk commented 7 years ago

Forgot to note that these are BREAKING CHANGES. On purpose, to export less.

codecov-io commented 7 years ago

Current coverage is 100% (diff: 100%)

Merging #24 into master will not change coverage

@@           master   #24   diff @@
===================================
  Files           6     6          
  Lines          60    58     -2   
  Methods         0     0          
  Messages        0     0          
  Branches        0     0          
===================================
- Hits           60    58     -2   
  Misses          0     0          
  Partials        0     0

Powered by Codecov. Last update df4efbe...2c311bd

rgbkrk commented 7 years ago

After we finish trimming we should make a 2.0.0 release.

rgbkrk commented 7 years ago

Hmmm, I'm tempted to get the terminals endpoint in before we do 2.0.0