search

nteract / rx-jupyter

🎈 RxJS 5 bindings for the Jupyter Notebook API
https://nteract.io/rx-jupyter
BSD 3-Clause "New" or "Revised" License
13 stars 10 forks source link

Terminals #30

Closed jdetle closed 8 years ago

jdetle commented 8 years ago

The tests currently aren't working and I'd love an extra pair of eyes to help me figure out why, thanks.

The current error is saying that list creates an AjaxObservable for listing available terminals: TypeError: Cannot read property 'url' of undefined

jdetle commented 8 years ago

@rgbkrk if you could take care of the websockets stuff I'm not entirely sure how to handle it.

codecov-io commented 8 years ago

Current coverage is 100% (diff: 100%)

Merging #30 into master will not change coverage

@@           master   #30   diff @@
===================================
  Files           6     7     +1   
  Lines          55    74    +19   
  Methods         0     0          
  Messages        0     0          
  Branches        0     0          
===================================
+ Hits           55    74    +19   
  Misses          0     0          
  Partials        0     0

Powered by Codecov. Last update d9c700b...cabc909

jdetle commented 8 years ago

@rgbkrk ready for merge?

jdetle commented 8 years ago

👍 thanks for the review!