nteract / scrapbook

A library for recording and reading data in notebooks.

https://nteract-scrapbook.readthedocs.io

BSD 3-Clause "New" or "Revised" License

281 stars 26 forks source link

Added schema versions to media payloads #30

Closed MSeal closed 5 years ago

MSeal commented 5 years ago

Now scrapbook/schemas/*.json will contain json schema files for evaluating payloads in display outputs.
Changed validation logic for decode/endcode functions to lean on jsonschema checks.
Scraps moved to their own file to avoid circular import issues
"version" added the output payload
More tests

codecov[bot] commented 5 years ago

Codecov Report

Merging #30 into master will increase coverage by 0.73%. The diff coverage is 96.05%.

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   95.49%   96.23%   +0.73%     
==========================================
  Files           7        9       +2     
  Lines         355      398      +43     
==========================================
+ Hits          339      383      +44     
+ Misses         16       15       -1

MSeal commented 5 years ago

Going to merge this as there's some bug fixes that need to follow and they conflict on testing. Let me know if there were still concerns and we can readdress.