nteract / scrapbook

A library for recording and reading data in notebooks.

https://nteract-scrapbook.readthedocs.io

BSD 3-Clause "New" or "Revised" License

281 stars 26 forks source link

Fixed reading string json elements from notebook store #44

Closed MSeal closed 5 years ago

MSeal commented 5 years ago

Fixes https://github.com/nteract/scrapbook/issues/43

Also record backwards compatibility tests were isolated to a separate notebook / tests rather than combining with the collection tests that read result1 and result2. Thus the large notebook changes can mostly be ignored as they're just rerunning the notebook with current api contract calls.

codecov[bot] commented 5 years ago

Codecov Report

Merging #44 into master will increase coverage by 0.02%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   96.43%   96.46%   +0.02%     
==========================================
  Files           9        9              
  Lines         393      396       +3     
==========================================
+ Hits          379      382       +3     
  Misses         14       14

codecov[bot] commented 5 years ago

Codecov Report

Merging #44 into master will decrease coverage by 0.43%. The diff coverage is 77.77%.

@@           Coverage Diff           @@
##           master   #44      +/-   ##
=======================================
- Coverage   96.43%   96%   -0.44%     
=======================================
  Files           9     9              
  Lines         393   400       +7     
=======================================
+ Hits          379   384       +5     
- Misses         14    16       +2