Closed trallard closed 5 years ago
We're just failing on the manifest, likely we just need to add the azure file to the MANIFEST.in file to make that pass.
If the azure test suite isn't working for python 2.7, that's fine and we can exclude it. We will be dropping support for 2.7 for all systems at the end of the year anyway as Carol mentioned.
Merging #53 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #53 +/- ##
=======================================
Coverage 95.74% 95.74%
=======================================
Files 10 10
Lines 447 447
=======================================
Hits 428 428
Misses 19 19
Merging #53 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #53 +/- ##
=======================================
Coverage 95.74% 95.74%
=======================================
Files 10 10
Lines 447 447
=======================================
Hits 428 428
Misses 19 19
Thanks for the PR!
Thanks @trallard 🎉 Faster tests FTW
@willingc I know we're going to drop the python 2.7 support at the end of the year, but I was wondering if you recognized how to circumvent the error in https://dev.azure.com/nteract/nteract/_build/results?buildId=4998 ? I tried to edit the requirements.txt but it sounds like there were some issues in pandas builds since Feburary because of some python tooling regarding installs that's preventing the older numpy from being visible to pandas in 2.7 -- any other builds that you know where this pattern works or maybe what to try next? If there isn't an obvious path forward I'll just nuke python 27 builds from azure and move on but thought I'd ask.
I'll take a look at it later today or tomorrow to see if there is a skip on fail for 2.7 or a numpy solution. I also see Tania on Thursday if we haven't resolved it ourselves ;-)
I only just realized that I missed some stuff in tox 🤦🏻♀️ sorry for that. Though I am happy to help so feel free to ping me at any time.
I think the pandas / numpy install path is somewhat broken for python 2 with recent versions as they're incorrectly pulling downstream libraries with versions that are not runnable in python 2 (registering in PyPI that they are) or aren't recognizing the install when installed in the same pip call. If we can't figure out a path forward easily soon I'll just rip the python 2 testing and announce it's deprecated with questionable support in the next release and set the release version where it will no longer run at all in the release after that.
I had multiple go's at this last night... and the most progress I got to was to actually get the install throwing a Python > 3.5 required
by using constraints.
So I agree the install for Python2.7 is broken now
Description
This PR adds
azure-pipelines.yml
which is needed to run the projects CI/CD using Azure pipelines.Note: The build pipeline still has to be set up for the repository on Azure DevOps. Note2: The pipeline fails for Python 2.7 but @willingc said it is no longer supported so it might be safe to remove it from the matrix
Checklist: