nteract / scrapbook

A library for recording and reading data in notebooks.

https://nteract-scrapbook.readthedocs.io

BSD 3-Clause "New" or "Revised" License

281 stars 26 forks source link

Pandas glue support #62

Closed MSeal closed 4 years ago

MSeal commented 4 years ago

This PR pulled pandas support from https://github.com/nteract/scrapbook/pull/37 and purely adds that transformation logic. Now calling glue on a pandas dataframe will encode it in base64 parquet text in the notebook. The S3 storage support will come in a later PR.

There are some limitations imposed on custom python types that can be nested within a dataframe by PyArrow. I tried to add some notes to the documentation about this limitation.

MSeal commented 4 years ago

Uhg, python 38 can't install arrow :/ Might need to put 38 tests out of travis until they get a valid wheel up for that python version.

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d68003e). Click here to learn what that means. The diff coverage is 100%.

@@           Coverage Diff            @@
##             master     #62   +/-   ##
========================================
  Coverage          ?   96.5%           
========================================
  Files             ?      10           
  Lines             ?     486           
  Branches          ?       0           
========================================
  Hits              ?     469           
  Misses            ?      17           
  Partials          ?       0

MSeal commented 4 years ago

@captainsafia You want to take one last pass on this before I merge?