Closed tanguycdls closed 3 years ago
Sorry I missed this issue @tanguycdls (was coming off paternity leave).
This seems like a good addition. I'd suggest renaming the argument to path_filter
but I'd be happy to merge such a PR if you want to make the addition.
Hello, thanks a lot for the package ! I have a small suggestion to improve the user experience.
When reading multiple notebooks from a folder it could be nice to be able to filter which notebook you want to open. In my use case our ipynb files are quite large (+1Mb) and so reading a folder with a large amount of notebooks can be slow.
My proposal would be a simple filter here in the code. I can open a pr if you want.
If you have a better idea to load our notebooks faster I would be happy to hear any suggestion, but given nformat api i'm not sure we can load scrapbook metadata faster ?