Closed hydrosquall closed 5 years ago
This looks great! Is there anything WIP about it that I need to take a look at or can I just merge it!?
I think it’s ready :)!
On Sun, Oct 6, 2019 at 2:26 PM Elijah Meeks notifications@github.com wrote:
This looks great! Is there anything WIP about it that I need to take a look at or can I just merge it!?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nteract/semiotic-docs/pull/18?email_source=notifications&email_token=ACE2MM2S27F422XKLJTHVE3QNIUU3A5CNFSM4I5ZNMOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAOQUBQ#issuecomment-538774022, or mute the thread https://github.com/notifications/unsubscribe-auth/ACE2MM6MVQLXWKX7W73YMGDQNIUU3ANCNFSM4I5ZNMOA .
Summary
Part of #17, based on https://github.com/nteract/semiotic/blob/master/src/docs/components/BarToParallel.js
Changes from the previous version
themes.js
folderfunnelData.js
to keep data + view code separateafterElements
the same Helvetica font as the chart label.<button>
since this version of the docs isn't using a component libraryThings tried but not kept
DocumentFrame
, but something about thestep
function props was creating an infinite loop even after I split into separateoverrideProps
andframeProps
. Decided against debugging it further since this isn't really a quickly copy-pasteable example in the way other chart types are anyways, looking at the Github Source file is probably the most practical thing to do.<p>
based captions toMarkdownText
after migrating one, even though newer components would probably prefer that syntax it didn't add much benefit.