nteract / semiotic-docs

Docs for using Semiotic
https://semiotic.nteract.io/
32 stars 12 forks source link

"Copy Full Code" not working on Safari #21

Open jefffriesen opened 4 years ago

jefffriesen commented 4 years ago

This is minor and annoying to fix but it was a stumbling block for me.

The "Copy Full Code" didn't copy anything and the examples didn't have the complete data in it. Because I didn't realize this worked other browsers, I went digging through the repo to find the data.

I think this is what's not supported in Safari: https://github.com/nteract/semiotic-docs/blob/1b9534ca45e920af9a1d4782e1cf2177f9548db3/src/DocumentFrame.js#L233

Unfortunately, I don't have time right now to make a PR.

I understand if you would want to mark this as wontfix and move on. If you do want to fix it, here are some resources: https://stackoverflow.com/questions/40147676/javascript-copy-to-clipboard-on-safari https://github.com/zenorocha/clipboard.js https://github.com/feross/clipboard-copy

Thanks