search

nteract / semiotic

A data visualization framework combining React & D3
https://semioticv1.nteract.io/
Other
2.44k stars 133 forks source link

Hard dep on json2csv 3.7 does not resolve #192

Closed cvkline closed 6 years ago

cvkline commented 6 years ago

Doing a clean npm install on a new project results in a node_modules tree containing an error that json2csv@3.7.4 is unresolved. I can successfully pull in the latest ^3 version of that module which is 3.11.5 but for some reason 3.7.4 can't be pulled. I don't know if that's a transient problem or what, but I thought I would mention it.

There don't appear to be any breaking changes until version 4, so this might be fairly easy to fix... I might give it a try; I thought I'd let you know about it in any case.

emeeks commented 6 years ago

You know I've heard json2csv giving people problems installing for a while but I never thought it was based on the version. This would be great to resolve, I was planning to just tear out the download feature entirely.

cvkline commented 6 years ago

I wonder if the resolution isn't as simple as upping the version to 3.11.5 and re-running tests?

There's probably also a way to create CSVs entirely in the d3 world. I may clone and fiddle.

emeeks commented 6 years ago

I'm looking into this with the hope of publishing a fix, did you see any other possible concerns?

cvkline commented 6 years ago

There appear to be no breaking changes with the latest version so presumably the answer to your question is no.

I just merged semiotic into our product's package.json and the busted 3.7.3 dep is apparently causing heartache with the automated build process, so this is becoming somewhat of an elevated priority for us.

It looks like for some weird reason, even though semiotic specified 3.7.3, 3.7.4 is what comes down from NPM, and then there's an unresolved dep.

ZachHaber commented 6 years ago

Something that I just noticed because I had to do a clean installation, if you install semiotic 1.9.1, run npm start, and then install semiotic 1.9.2, it works. (don't know if starting create-react-app's start script is actually necessary for this workaround).

cvkline commented 6 years ago

That's very odd, because the only change in package.json between 1.9.1 and 1.9.2 was the version bump to semiotic itself. This is very confusing.

ZachHaber commented 6 years ago

Yeah, it really is odd, I even tried directly copying the node_modules/semiotic folder from the old repository (where it was working) to the new one I had just clean installed, and the error remained. It wasn't until I switched semiotic versions that the error resolved itself.

cvkline commented 6 years ago

I just made pull request #196 which is pretty trivial but does seem to fix the version error.

emeeks commented 6 years ago

Updated in 1.9.3