search

nteract / semiotic

A data visualization framework combining React & D3
https://semioticv1.nteract.io/
Other
2.44k stars 133 forks source link

Radial chart variable column heights depend on the data entry field name #462

Closed artemverbo closed 4 years ago

artemverbo commented 5 years ago

Hi!

I'm having a bit of an odd issue with radial charts column heights, not widths.

1) When my data entries have an r field called value and I set dynamicColumnWidth: 'value' (or via function, doesn't matter), I get elements rendered with variable heights like so: Screen Shot on 2019-04-17 at 13-08-16

2) As soon as I rename the data field to anything other than value, say to v and use dynamicColumnWidth: 'v', it seems to behave as expected: Screen Shot on 2019-04-17 at 13-09-57

Is that a bug or kind of an undocumented feature? :)

Thanks!

emeeks commented 5 years ago

This is a bug that probably won't be fixed until 2.0 based on how the individual pieces are being decorated. The generated datapoint is an object with a data prop that corresponds to the original datapoint and a value prop that encodes the value (based on your accessor) onto the generated object. Earlier on I used JS symbols to avoid these kinds of collisions but they proved messy and difficult to then translate them back to the user.

The reason I probably won't fix this before 2.0 is because it only happens in these corner cases and also I can't change the generated object spec, which gets exposed in some places, without a major version change.