nteract / semiotic

A data visualization framework combining React & D3
https://semioticv1.nteract.io/
Other
2.43k stars 133 forks source link

XY Brush component bug #512

Closed moona3k closed 4 years ago

moona3k commented 4 years ago

Live demo of the bug is found in the XY Brush example in the below link: https://semiotic.nteract.io/guides/xy-brushes

Issue: interaction prop enables a brush-like interactive region that you can move and adjust width. When you click anywhere outside of the interactive region in the XYFrame component, the program crashes. Refer to screenshots below:

Screen Shot 2020-01-16 at 4 40 14 PM

Screen Shot 2020-01-16 at 4 37 34 PM

Screen Shot 2020-01-16 at 4 42 19 PM

emeeks commented 4 years ago

Do you see this happening in the local version or only in the online documentation? I need to update the online docs and I can't reproduce it locally so I think it's because the docs are a few versions back. I will dig into updating the docs now.

emeeks commented 4 years ago

Fixed in 1.20.5