AnnotationCalloutElbow note title doesn't re-render when the value it uses changes

nteract / semiotic

A data visualization framework combining React & D3

https://semioticv1.nteract.io/

Other

2.43k stars 133 forks source link

AnnotationCalloutElbow note title doesn't re-render when the value it uses changes #530

Closed vizowl closed 4 years ago

vizowl commented 4 years ago

I am using semiotic 2.0.0-rc.5 and it appears that react-annotation note titles and and labels do not respond to changes once they have first been rendered.

I have setup a minimal version of the issue here https://github.com/vizowl/semiotic-annotations-issue

I also played with things like creating annotation objects (and arrays) and then using the spread operator to pass them to the XYFrame to see if always creating the object helped - but it didn't.

emeeks commented 4 years ago

This should be fixed in rc7 please take a look and let me know.

vizowl commented 4 years ago

Thanks - it all looks good to me