Closed ShadyStego closed 2 years ago
@ShadyStego Thanks for the PR! Heads up: looks like you had a bad merge somewhere and the diff is now huge.
Thanks, @captainsafia . I think I tried to merge it to the wrong branch (master). I intended to merge with semiotic-2. Let me take a look.
I've updated the target to the right branch. The test failed though, possibly typescript related.
Odd, seems to be trying to fetch dependencies from npm.apple.com registry, which is probably not exposed to the outside. 😅
@emeeks Might have thoughts on this.
I've evaluated Popper.js and React-Popper (docs), and they seem to be a solid library to use to support dynamic tooltips. It supports optimized arrow placement too. In the future we can open up a few of their settings if make sense.
This will be a breaking change to the previous version that I implemented from scratch. Let me know if we need to be backward compatible.
Here is the suggested CSS (very similar to their tutorials, with a few tweaks and comments to support borders):
(cc @emeeks , @MichielDeMey)