search

nteract / semiotic

A data visualization framework combining React & D3
https://semioticv1.nteract.io/
Other
2.43k stars 132 forks source link

Remove old docs dev build and modernize #567

Closed willingc closed 2 years ago

willingc commented 2 years ago

Addresses #566

We can remove the "gh-pages" script after all is running on vercel.

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nteract/semiotic/8jMBp46p9GY9HBA2N8icjpMjbzJK
✅ Preview: https://semiotic-git-modernize-doc-nteract.vercel.app

willingc commented 2 years ago

@alexeyraspopov Getting a weird types and transformer error from Parcel. I think it is unhappy with the html file for dev docs. Screen Shot 2021-12-16 at 9 50

Thoughts? Only found a cryptic old issue on the Parcel site which wasn't very helpful.

alexeyraspopov commented 2 years ago

@willingc I'm gonna figure this one out asap

alexeyraspopov commented 2 years ago

@willingc, yeah, I know what's up. Parcel relies on some fields in package.json that actually only needed for the library. I know a workaround for this, brb

willingc commented 2 years ago

Cool! Feel free to push directly to this PR or create a new PR and I will rebase this on top.

alexeyraspopov commented 2 years ago

@willingc, https://github.com/nteract/semiotic/pull/567/commits/7fb8811d93c60a09df9699f70532da95d388baf2 should do the trick. I defined a separate target config for Parcel so it doesn't bother looking into fields like engines, main, and types.

willingc commented 2 years ago

Awesome! I'm going to merge. After my call I will update Vercel to display if I am able.