search

nteract / semiotic

A data visualization framework combining React & D3
https://semioticv1.nteract.io/
Other
2.43k stars 133 forks source link

Upgrade react to v17.0.2 #568

Closed alexeyraspopov closed 2 years ago

alexeyraspopov commented 2 years ago

Initially I wanted to update tests first, by replacing Enzyme with React Testing Library, but that seem to take too much time given that tests are pretty low level comparing to what RTL expects tests to be. We can still do it eventually. Meanwhile, I found Enzyme adapter for React v17 that seem to be pretty popular (https://www.npmjs.com/package/@wojtekmaj/enzyme-adapter-react-17) and the tests seems happy about it as well.

I would rather spent some time fixing some small bugs that I started encountering and making local dev docs look more like a styleguide/storybook sort of sandbox. Hopefully, as a part of those fixes we'll get more tests written

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nteract/semiotic/8KwYHjqsVHesTcadvoGqHhNwwfXf
✅ Preview: Failed

willingc commented 2 years ago

Thanks! Looks good.

willingc commented 2 years ago

Closes #545