search

nteract / semiotic

A data visualization framework combining React & D3
https://semioticv1.nteract.io/
Other
2.43k stars 133 forks source link

Export existing typescript type definitions #594

Closed alexeyraspopov closed 2 years ago

alexeyraspopov commented 2 years ago

As I published rc18 and started testing it, I realized that with an updated structure and lack of access to internal files structure it is impossible to import TypeScript types (e.g. MarginType, ProjectedBin, etc) which may have negative impact on TS experience. While existing types and access to them was never documented, it is worth considering what experience we would like to provide: what kind of types need to be exported and made use of, what contracts developers are using for common tasks, etc.

In this PR I'm making all previously available types exported from the package, so we can continue testing new RCs in TypeScript environment. I'll be publishing rc19 with these updates (and including the rest of recent updated in main). The exports do not affect the the library size, only .d.ts files.

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nteract/semiotic/BUogCYGjwiTHGeb9LLQ82CnzHFtn
✅ Preview: Failed

alexeyraspopov commented 2 years ago

@emeeks 2.0.0-rc.19 has been published, including these changes and latest code from main.