nteract / semiotic

A data visualization framework combining React & D3
https://semioticv1.nteract.io/
Other
2.43k stars 132 forks source link

Fix oSort on Dynamic Width bug #600

Closed emeeks closed 2 years ago

emeeks commented 2 years ago

This fixes #599 where if you set oSort and have dynamicColumnWidth it does not sort the items properly. All the fix does is move the column range calculation after the sorting occurs (because sorting changes the way the dynamic column widths are calculated).

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nteract/semiotic/26MaFgAvQaRHVKTgfKRu9LwvYcBj
✅ Preview: https://semiotic-git-fix-osort-with-dynamic-width-nteract.vercel.app