search

nteract / semiotic

A data visualization framework combining React & D3
https://semioticv1.nteract.io/
Other
2.43k stars 132 forks source link

Canvas Rendering Doesn't Initially Render #609

Closed emeeks closed 2 years ago

emeeks commented 2 years ago

The current examples don't seem to render when canvas rendering is set to true on the initial load. You can see this in the old docs in the canvas interaction or the XYFrame Overview docs when you set canvas rendering to "all". It's not clear when this happened.

alexeyraspopov commented 2 years ago

I was able to reproduce this bug before and after #608 was merged. Will see what's happening under the hood

alexeyraspopov commented 2 years ago

So "canvasinteraction" was failing due to diamonds.csv file being unable to load, I'm fixing it.

alexeyraspopov commented 2 years ago

ok, I identified the issue with XYFrame Overview not rendering canvas after the props change. Seems like an actual bug somewhere between Frame and VisualizationLayer, gonna fix it as a part of the previously mentioned thing