search

nteract / semiotic

A data visualization framework combining React & D3
https://semioticv1.nteract.io/
Other
2.43k stars 132 forks source link

Remove redundant attribute [Was: class and className entries] #610

Open dgwyer opened 2 years ago

dgwyer commented 2 years ago

While inspecting some of the rendered SVG code I noticed that some group elements contain a mixture of class and className attributes. The className attribute appears to mirror the class attribute.

See this screenshot for an example:

image6

In the rendered markup should we be outputting a class attribute only?

alexeyraspopov commented 2 years ago

In the rendered markup should we be outputting a class attribute only?

It should, good catch! At the very least class itself is still present which means there is no functional bug, but redundant attribute definitely worth removing.