nteract / semiotic

A data visualization framework combining React & D3
https://semioticv1.nteract.io/
Other
2.43k stars 132 forks source link

Use local build of semiotic on the website #615

Closed alexeyraspopov closed 2 years ago

alexeyraspopov commented 2 years ago

This should make it easier to catch bugs early and be able to introduce new functionality/changes along with related documentation without a need to do additional rounds of publishing and updating the website.

I couldn't think of any smarter solution to define a dependency and the fact that the library needs to be built before the website can be served or bundled, so let's start with something straightforward. I'd imagine it can be annoying if you need to restart a website locally often, but the fact the library takes just seconds to build should not be a critical issue.

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nteract/semiotic/3Wo3sVZrWoZf1cfrwFeS5n9aAcdH
✅ Preview: https://semiotic-git-prebuildsemiotic-nteract.vercel.app

willingc commented 2 years ago

Thanks @alexeyraspopov.