SVG notes on annotations can cause rerender issues

nteract / semiotic

A data visualization framework combining React & D3

https://semioticv1.nteract.io/

Other

2.43k stars 133 forks source link

SVG notes on annotations can cause rerender issues #629

Closed emeeks closed 2 years ago

emeeks commented 2 years ago

Due to the way we track dependencies on the useEffect in AnnotationLayer we can experience unnecessary rerenders if a user declares an SVG node as a note.

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nteract/semiotic/BTN7VtVeWC1XimuU5xPJss1nd7Ab
✅ Preview: https://semiotic-git-fix-svg-notes-nteract.vercel.app