Use redux for direct communication for tooltips

nteract / semiotic

A data visualization framework combining React & D3

https://semioticv1.nteract.io/

Other

2.43k stars 132 forks source link

Use redux for direct communication for tooltips #637

Closed emeeks closed 2 years ago

emeeks commented 2 years ago

I've resisted adding Redux to the project but passing down the tooltip function causes so much trouble and direct communication between InteractionLayer, VisualizationLayer and AnnotationLayer for tooltips is so much more sensible and performant.

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
semiotic	✅ Ready (Inspect)	Visit Preview	Jun 28, 2022 at 5:19PM (UTC)

alexeyraspopov commented 2 years ago

Looking at the amount of errors, it may be better to postpone move to React 18. You can use useSyncExternalStore from use-sync-external-store/shim which has a proper fallback in React 17