nteract / testbook

🧪 📗 Unit test your Jupyter Notebooks the right way

https://testbook.readthedocs.io

BSD 3-Clause "New" or "Revised" License

420 stars 37 forks source link

Mimic patch for decorator and pytest fixtures #77

Closed fcollonval closed 3 years ago

fcollonval commented 3 years ago

Fix #75

Edit: this is quite hacky. It may be better to use a third-party library (like decorator) to hack the function signature; actually this is where pytest fixture and a decorator get messy.

fcollonval commented 3 years ago

The errors are the same as in #76 - and they seem unrelated

rohitsanj commented 3 years ago

Thanks for the quick fix @fcollonval! I apologize that I could not get to this PR sooner, I have been caught up with work lately.

Looks like the CI is passing now. It is likely that a buggy release of some dependency could have caused this. I'm not entirely sure.

codecov-io commented 3 years ago

Codecov Report

Merging #77 (1f5a03b) into master (5fcca72) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #77   +/-   ##
=======================================
  Coverage   99.66%   99.66%           
=======================================
  Files           7        7           
  Lines         301      303    +2     
=======================================
+ Hits          300      302    +2     
  Misses          1        1