nteract / vdom

🎄 Virtual DOM for Python
https://github.com/nteract/vdom/blob/master/docs/mimetype-spec.md
BSD 3-Clause "New" or "Revised" License
222 stars 35 forks source link

tests for event handler support needed #69

Closed mpacer closed 5 years ago

mpacer commented 6 years ago

The recent change in #68 to encode styles in attributes broke the changes in #44. Which I didn't notice when I gave the thumbs up on rebasing and merging.

This wasn't caught automatically because there weren't any tests for how callbacks are intended to be handled.

@gnestor would you write some tests for this functionality? After that we'll need to work on reimplementing the attribute encoding so that those tests pass appropriately.