Move event handlers out of attributes

gnestor commented 5 years ago

Closes https://github.com/nteract/vdom/issues/70

This leaves the UX the same:

my_button = button('Click me', onClick=handle_click)

However, it moves event handlers out of VDOM.attributes so that they can be handled separately from regular attributes.

This also modifies the message spec to make eventHandlers a top-level property.

A couple point to discuss:

Should event_handlers be a new argument in VDOM
There is duplicate logic for extracting event handlers from attributes in from_dict and create_component. Same for extracting style from attributes. Perhaps we should revisit how this is done?
Event handlers are extracted in from_dict and create_component (on creation) and serialized on VDOM.to_dict
When serializing event handlers, it returns a target name string vs. object now

rgbkrk commented 5 years ago

Thank you Grant!

@yuvipanda if you get a chance I'd love for you to look over this PR as we work on getting the next VDOM release out. We're in a bit of a standstill with some good changes both for using vdom as templates and for interactive notebookiness. Now the event handlers are being moved to a new top level key (that we can ignore for HTML out) and I'd love to get your feedback.

rgbkrk commented 5 years ago

Ready to ship this @gnestor?

nteract / vdom

Move event handlers out of attributes #76