Open coiby opened 1 month ago
Hi, thanks for the report. I don't see anything wrong with the configuration. However, in the job you linked, the write permission for pull requests doesn't actually seem to get set:
Thanks for finding GITHUB_TOKEN doesn't have write permission! I did a further look and noticed this comment,
Because your PRs come from a public fork, GITHUB_TOKEN only has read permissions (see here). You might be able to get write permissions by using pull_request_target as the trigger.
Indeed Maximum access for pull requests from public forked repositories is read for all scopes including pull-request.
Thanks @coiby for investigating! Is there something I need to change on my side?
Hi,
Thanks for creating this GitHub App action! I tried adding it to one repo but somehow the jobs failed (e.g. this job) with the following logs,
The added Github Action yaml is the same to https://github.com/glass-dev/glass/blob/main/.github/workflows/pull_request_review.yml except for the job name and I use the default Workflow permissions as shown below,![Screenshot_2024-07-17_08-36-43](https://github.com/user-attachments/assets/871eaa20-5d81-4432-bc83-3877b86355d5)
So I'm not sure what's wrong. Can you give a clue? Thanks!