search

ntex-rs / ntex-amqp

AMQP 1.0 Server framework
Apache License 2.0
66 stars 15 forks source link

dont remove session before confirmation #16

Closed wpbrown closed 2 years ago

wpbrown commented 2 years ago

Removing the session from the map while handling the remote end frame causes the dispatcher to fail due to unknown session when the response frame is handled.

fafhrd91 commented 2 years ago

i dont see how we going to remove session. if we get remote end frame, we respond with end , but at this point we wont get any further frames for this session and session stays in map. do i miss something?

codecov[bot] commented 2 years ago

Codecov Report

Merging #16 (d87cfea) into master (e5fcc1f) will increase coverage by 0.08%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   53.08%   53.17%   +0.08%     
==========================================
  Files          35       35              
  Lines        3805     3801       -4     
==========================================
+ Hits         2020     2021       +1     
+ Misses       1785     1780       -5
Impacted Files Coverage Δ
src/connection.rs 67.61% <50.00%> (+3.16%) :arrow_up:
src/server/service.rs 64.75% <0.00%> (-0.82%) :arrow_down:
src/dispatcher.rs 46.55% <0.00%> (-0.58%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e5fcc1f...d87cfea. Read the comment docs.