ntex-rs / ntex-amqp

AMQP 1.0 Server framework
Apache License 2.0
65 stars 15 forks source link

agree with remote terminus on snd-settle-mode #9

Closed wpbrown closed 3 years ago

wpbrown commented 3 years ago

amqp 1.0 spec

snd-settle-mode
The delivery settlement policy for the sender. When set at the receiver
this indicates the desired value for the settlement mode at the sender.
When set at the sender this indicates the actual settlement mode in use.

It should not matter what the local terminus sends back when the attach is initiated by a remote terminus. The sender sets the actual settlement mode.

However some AMQP clients incorrectly change their send settlement mode based on this response. This change makes the attach response use the same mode to deal with such clients. Compliant clients will ignore this field in the response.

codecov[bot] commented 3 years ago

Codecov Report

Merging #9 (b94780e) into master (5b5f2b7) will decrease coverage by 0.00%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
- Coverage   28.73%   28.72%   -0.01%     
==========================================
  Files          38       38              
  Lines        6160     6161       +1     
==========================================
  Hits         1770     1770              
- Misses       4390     4391       +1     
Impacted Files Coverage Δ
src/session.rs 0.00% <0.00%> (ø)
codec/src/protocol/definitions.rs 22.11% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5b5f2b7...b94780e. Read the comment docs.