search

ntex-rs / ntex

framework for composable networking services
Apache License 2.0
1.84k stars 105 forks source link

fix(github-actions): use rust toolchain arm64 version for macos 14 #355

Closed msga-mmm closed 1 month ago

msga-mmm commented 1 month ago

The tests on MacOS runner were failing due to an error in the linking step:

= note: ld: warning: ignoring file '/opt/homebrew/Cellar/openssl@3/3.3.0/lib/libssl.3.dylib': found architecture 'arm64', required architecture 'x86_64'

The tests seem to have started to fail recently which might be related to the update of macos 12 to 14 when using the tag macos-latest in the github runner:

One month ago: image

Recently: image

It could be fixed by pinning the macos version to 12 or using the arm64 version toolchain.

In this pull request I updated the macos tests to use the arm64 version in case this results useful.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.70%. Comparing base (33490cd) to head (60d08f9). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #355 +/- ## ========================================== + Coverage 90.64% 90.70% +0.06% ========================================== Files 197 197 Lines 31653 31664 +11 ========================================== + Hits 28691 28720 +29 + Misses 2962 2944 -18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fafhrd91 commented 1 month ago

thanks!