search

nth-cloud / ng-mentions

Rich Mentions Component for Angular
http://nth-cloud.github.io/ng-mentions
MIT License
12 stars 12 forks source link

Removing console log on the mentionList component and extending the behavior of mentions #41

Closed Gray-Simon closed 1 year ago

Gray-Simon commented 2 years ago

Please remember, the issues forum is NOT for support requests. It is for bugs and feature requests only. Please search existing issues (both open and closed) prior to opening any new issue and ensure you follow the instructions therein.

Bug description: kindly remove the console log on the mention-list component for data integrity sake. especially for users returning an array of objects .

1. See below code to streamline your search.

onItemClick(event: MouseEvent, activeIndex: number, item: any) { event.preventDefault(); console.log(item); // kindly remove the console log. if (item) { this.activeIndex = activeIndex; this.itemSelected.emit(item); } } 2. is it possible we have multiple mention configuration with each configuration having their specific triggerCharacter and mentions object e.t.c

Link to minimally-working plunker that reproduces the issue:

You can fork a plunker from one of our demos and use it as a starting point. Please note that we can not act on bug reports without a minimal reproduction scenario in plunker.

Version of Angular and ng-mentions:

Angular:

ng-mentions:

trickeyone commented 2 years ago

@Gray-Simon Sorry, it's not currently possible to have multiple trigger characters and would be fairly complicated to change the existing behavior to try to add it. If you want to try and take a crack at it, pull requests are always welcome. I don't currently have the bandwidth to try an tackle it myself right now.

I'll try to get a revision out removing the console.log call in the next few days.

stale[bot] commented 2 years ago

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue in 24 hours. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please do feel free to either reopen this issue or open a new one. We'll gladly take a look again!